| Violation | Line |
|---|---|
| Substitute calls to size() == 0 (or size() != 0) with calls to isEmpty() - details... | 86 |
| Avoid if (x != y) ..; else ..; - details... | 92 |
| The String literal "Fileupload failed: " appears 4 times in this file; the first occurrence is on line 108 - details... | 108 |
| Avoid if (x != y) ..; else ..; - details... | 120 |
| Violation | Line |
|---|---|
| Private field 'context' could be made final; it is only initialized in the declaration or constructor. - details... | 24 |
| No need to check for null before an instanceof - details... | 33 |
| Violation | Line |
|---|---|
| Private field 'matchers' could be made final; it is only initialized in the declaration or constructor. - details... | 32 |
| Overridable method 'addMatcher' called during object construction - details... | 36 |
| Overridable method 'addMatcher' called during object construction - details... | 37 |
| Overridable method 'addMatcher' called during object construction - details... | 38 |
| Overridable method 'addMatcher' called during object construction - details... | 39 |
| Overridable method 'addMatcher' called during object construction - details... | 40 |
| Overridable method 'addMatcher' called during object construction - details... | 41 |
| Violation | Line |
|---|---|
| String.indexOf(char) is faster than String.indexOf(String). - details... | 64 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks - details... | 37 |
| Avoid appending characters as strings in StringBuffer.append. - details... | 81 |
| Avoid appending characters as strings in StringBuffer.append. - details... | 87 |
| Violation | Line |
|---|---|
| Private field 'webdavService' could be made final; it is only initialized in the declaration or constructor. - details... | 34 |
| Private field 'cacheHandler' could be made final; it is only initialized in the declaration or constructor. - details... | 35 |
| These nested if statements could be combined - details... | 50 |
| No need to call String.valueOf to append to a string. - details... | 151 |
| Violation | Line |
|---|---|
| String.indexOf(char) is faster than String.indexOf(String). - details... | 58 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; - details... | 41 |
| Violation | Line |
|---|---|
| Avoid if (x != y) ..; else ..; - details... | 58 |
| Violation | Line |
|---|---|
| Document empty method - details... | 107 |
| Document empty method - details... | 110 |
| Document empty method - details... | 113 |
| Document empty method - details... | 116 |
| Document empty method - details... | 119 |
| Violation | Line |
|---|---|
| This class has a bunch of public methods and attributes - details... | 16 |
| Private field 'queryStr' could be made final; it is only initialized in the declaration or constructor. - details... | 34 |
| Document empty method - details... | 244 |
| Document empty method - details... | 247 |
| Document empty method - details... | 250 |
| Violation | Line |
|---|---|
| JUnit tests should include assert() or fail() - details... | 32 |
| JUnit tests should include assert() or fail() - details... | 51 |
| JUnit tests should include assert() or fail() - details... | 63 |
| JUnit tests should include assert() or fail() - details... | 76 |